fix: resolve 5 bugs identified in code review

- Fix malformed YAML in config_test.go (incorrect indentation)
- Add validation for empty file_extensions in Config.Validate()
- Remove obsolete max_depth test case (field no longer exists)
- Remove unused global cfg variable in main.go
- Fix race condition in ScrapeSites by counting URLs before goroutines
- Remove unreachable JavaScript code in scroll script, add proper delay
- Standardize file extensions to not include leading dot
This commit is contained in:
Claude
2025-11-27 15:56:37 +00:00
parent 7569aff6ec
commit 09608cf073
5 changed files with 18 additions and 24 deletions

View File

@@ -88,6 +88,10 @@ func Load(configPath string) (*Config, error) {
// Validate checks the configuration for any invalid values
func (c *Config) Validate() error {
if len(c.FileExtensions) == 0 && len(c.Sites) == 0 {
return fmt.Errorf("file_extensions or sites must be specified")
}
if c.RequestsPerSecond != nil && *c.RequestsPerSecond <= 0 {
return fmt.Errorf("requests_per_second must be positive")
}

View File

@@ -10,8 +10,8 @@ func TestLoad(t *testing.T) {
// Create a temporary config file
content := []byte(`
file_extensions:
- .go
- .md
- go
- md
ignore_paths:
- "*.tmp"
- "**/*.log"
@@ -27,7 +27,7 @@ sites:
- "/blog"
exclude_paths:
- "/admin"
file_name_prefix: "example"
file_name_prefix: "example"
path_overrides:
- path: "/special"
css_locator: ".special-content"
@@ -61,7 +61,7 @@ burst_limit: 5
rps := 1.0
bl := 5
expectedConfig := &Config{
FileExtensions: []string{".go", ".md"},
FileExtensions: []string{"go", "md"},
IgnorePaths: []string{"*.tmp", "**/*.log"},
CodeGeneratedPaths: []string{"generated_*.go"},
Sites: []SiteConfig{
@@ -100,7 +100,7 @@ func TestValidate(t *testing.T) {
{
name: "Valid config",
config: Config{
FileExtensions: []string{".go"},
FileExtensions: []string{"go"},
Sites: []SiteConfig{
{BaseURL: "https://example.com"},
},
@@ -115,7 +115,7 @@ func TestValidate(t *testing.T) {
{
name: "Invalid requests per second",
config: Config{
FileExtensions: []string{".go"},
FileExtensions: []string{"go"},
RequestsPerSecond: func() *float64 { f := -1.0; return &f }(),
},
wantErr: true,
@@ -123,7 +123,7 @@ func TestValidate(t *testing.T) {
{
name: "Invalid burst limit",
config: Config{
FileExtensions: []string{".go"},
FileExtensions: []string{"go"},
BurstLimit: func() *int { i := -1; return &i }(),
},
wantErr: true,
@@ -131,19 +131,11 @@ func TestValidate(t *testing.T) {
{
name: "Site without base URL",
config: Config{
FileExtensions: []string{".go"},
FileExtensions: []string{"go"},
Sites: []SiteConfig{{}},
},
wantErr: true,
},
{
name: "Negative max depth",
config: Config{
FileExtensions: []string{".go"},
Sites: []SiteConfig{{BaseURL: "https://example.com"}},
},
wantErr: true,
},
}
for _, tt := range tests {